feat(settings): Add RTTTL ringtone playback in settings#3799
Merged
Conversation
This commit introduces a "Play" button next to the RTTTL ringtone input field in the External Notification settings screen. Tapping this button will play the entered RTTTL string, allowing users to preview the ringtone directly on their phone. - Added a play icon button to the `TextFieldPreference` for the ringtone. - Implemented playback logic using `MediaPlayer` by writing the RTTTL string to a temporary file. - Added a new string resource for the "Play" button's content description. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This commit introduces a file import functionality for the RTTTL ringtone on the External Notification settings screen. - Adds a "Folder" icon button to open the system file picker. - Implemented logic to read the selected file's content and populate the ringtone text field. - Added user feedback via Toast messages for successful imports, empty files, or errors. - Minor refactoring to pass a `Modifier` to `RadioConfigScreenList` and `ExternalNotificationConfigScreen`. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3799 +/- ##
========================================
- Coverage 0.55% 0.54% -0.02%
========================================
Files 381 386 +5
Lines 21861 22463 +602
Branches 2708 2814 +106
========================================
Hits 122 122
- Misses 21719 22320 +601
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. |
…nfigScreen Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds RTTL import and playback to External Notification settings.
screen-20251124-115738-1764007036070.mp4