refactor: Improve RSSI reading robustness in connection info#3798
Merged
Conversation
This commit adds a try-catch block around the `readRssi()` call within the `CurrentlyConnectedInfo` composable.
- This prevents the application from crashing if reading the RSSI fails for any reason.
- An error is now logged using `Timber` instead of crashing the coroutine.
- Added `@Suppress("TooGenericExceptionCaught")` to acknowledge catching the generic `Exception`.
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3798 +/- ##
========================================
- Coverage 0.55% 0.55% -0.01%
========================================
Files 381 381
Lines 21861 21862 +1
Branches 2708 2708
========================================
Hits 122 122
- Misses 21719 21720 +1
Partials 20 20 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a try-catch block around the
readRssi()call within theCurrentlyConnectedInfocomposable.Timberinstead of crashing the coroutine.@Suppress("TooGenericExceptionCaught")to acknowledge catching the genericException.