fix: unread count racecondition#3784
Merged
jamesarich merged 3 commits intoNov 22, 2025
Merged
Conversation
- Log when LaunchedEffect starts/restarts in UpdateUnreadCount - Log when debounce triggers and clearing conditions - Log message state changes and clearing attempts - Log clearUnreadCount function calls and results This will help identify why the unread divider never clears.
98b6d76 to
2f6e8e5
Compare
2f6e8e5 to
17a786d
Compare
jamesarich
approved these changes
Nov 22, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3784 +/- ##
========================================
- Coverage 0.56% 0.56% -0.01%
========================================
Files 381 381
Lines 21733 21738 +5
Branches 2684 2683 -1
========================================
Hits 122 122
- Misses 21591 21596 +5
Partials 20 20 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause:
The unread count clearing mechanism had a race condition when users sent messages during the debounce period. The LaunchedEffect was keyed on the entire messages list, which meant:
Changes Made:
Fixed race condition in UpdateUnreadCount
Simplified and corrected unread marking logic
Reduced debounce time
Improves responsiveness while still preventing database thrashing during scrolling