Skip to content

Feat request neighbours#3709

Merged
DaneEvans merged 18 commits into
meshtastic:mainfrom
DaneEvans:feat_request_neighbours
Dec 21, 2025
Merged

Feat request neighbours#3709
DaneEvans merged 18 commits into
meshtastic:mainfrom
DaneEvans:feat_request_neighbours

Conversation

@DaneEvans

Copy link
Copy Markdown
Collaborator

Requires meshtastic/firmware#8523

Adds a button to node details to request neighbours from a node.

@github-actions github-actions Bot added the enhancement New feature or request label Nov 15, 2025
@codecov

codecov Bot commented Dec 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 183 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.60%. Comparing base (3e3dfe0) to head (fae4a51).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/com/geeksville/mesh/service/MeshService.kt 0.00% 76 Missing ⚠️
app/src/main/java/com/geeksville/mesh/ui/Main.kt 0.00% 61 Missing ⚠️
...eshtastic/feature/node/component/CooldownButton.kt 0.00% 17 Missing ⚠️
...htastic/feature/node/detail/NodeDetailViewModel.kt 0.00% 9 Missing ⚠️
...meshtastic/feature/node/component/DeviceActions.kt 0.00% 5 Missing ⚠️
...stic/feature/node/component/RemoteDeviceActions.kt 0.00% 4 Missing ⚠️
...tic/feature/map/cluster/RadiusMarkerClusterer.java 0.00% 3 Missing ⚠️
...g/meshtastic/feature/node/detail/NodeDetailList.kt 0.00% 3 Missing ⚠️
...src/main/java/com/geeksville/mesh/model/UIState.kt 0.00% 2 Missing ⚠️
...meshtastic/feature/node/detail/NodeDetailScreen.kt 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3709      +/-   ##
========================================
- Coverage   0.60%   0.60%   -0.01%     
========================================
  Files        406     406              
  Lines      24283   24457     +174     
  Branches    3121    3153      +32     
========================================
  Hits         148     148              
- Misses     24112   24286     +174     
  Partials      23      23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread app/src/main/java/com/geeksville/mesh/service/MeshService.kt Outdated

@jamesarich jamesarich left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from or vs our inconsistence - this is looking pretty good 👍

@DaneEvans

Copy link
Copy Markdown
Collaborator Author

It also pops up on every Neighbour packet, or when one arrives while the app is closed.

I need to fix that. Was hoping to test it on new FW, but then the new FW didn't play nice.

@DaneEvans DaneEvans marked this pull request as ready for review December 21, 2025 09:09
@DaneEvans

DaneEvans commented Dec 21, 2025

Copy link
Copy Markdown
Collaborator Author

Calling this ready - I'd like to suggest that we flag an 'info' tooltip or similar for menu items.

  • This (only new FW targets, and needs to be turned on etc.) ,
  • metadata (wtf is that to the uninitiated) ,
  • remote admin (why it might fail / how to set up )
    and a few others could do with it, but it'll be a feature that we have to add to the listItems in a coherent way.

@DaneEvans DaneEvans added this pull request to the merge queue Dec 21, 2025
Merged via the queue into meshtastic:main with commit d33229c Dec 21, 2025
6 checks passed
@DaneEvans DaneEvans deleted the feat_request_neighbours branch December 21, 2025 21:05
@garthvh

garthvh commented Dec 22, 2025

Copy link
Copy Markdown
Member

This is a pretty expensive action, and does not really work with recent firmware. Hard on the mesh and will fail a lot, probably not a great feature as the firmware works currently.

@HougeDK

HougeDK commented Dec 31, 2025

Copy link
Copy Markdown

Hi.
I see there is now a button for this in the beta app. But how does it work, when i press it, nothing happens here ?
Iam excited about this, as its very useful when you build remote nodes with no internet access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants