Skip to content

[Bug]: Relay node resolution may select local or unseen nodes #4036

Description

@emp3r0r7

Contact Details

No response

Checklist

  • I am able to reproduce the bug with the latest version.

  • I have updated to the latest Alpha firmware, and am able to reproduce the bug. Many issues are fixed quickly in alpha before the general beta release.

  • I made sure that there are no existing OPEN or CLOSED issues which I could contribute my information to.

  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.

  • This issue contains only one bug.

  • I have read and understood the Contribution Guidelines.

  • I agree to follow this project's Code of Conduct

  • I actually read this list, and should be taken seriously.

Affected app version

2.7.8

Affected Android version

Android 13

Affected phone model

Samsung A32

Affected node model

HeltecV4 but its not firmware fault

Affected node firmware version

2.7.15 but its not firmware fault

Steps to reproduce the bug

By attaching the debugger and stepping through the relay node resolution code
(e.g. Packet.getRelayNode()), it is possible to observe that, in some cases, the local
node is selected as a relay candidate.
The method lacks a check to prevent the local node from being selected as a relay
candidate and avoid nodes with lastseen not set as 0

Actual behavior

No response

Expected behavior

No response

Screenshots/Screen recordings

No response

Relevant log output

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions