SDK3.x: Fix OTA includes, bump Async version#2306
Conversation
|
@ripplebiz this seems as good addition - esp32c6 boards were cut-off from OTAs because of incompatibility with Arduino 3.x |
|
Tests we have done:
Will merge, thanks! :) |
|
@liamcottle was it also tested on this new firmware to update over OTA to another new firmware? Currently I am running the Dev branch from May 11th and trying to do an OTA to the current Dev branch which does not seem to work. Device: Heltec V4.3
So basically everything works, except that it stays on the previous firmware version. |
This is something what I saw on different project. Maybe there is meanwhile something what is initialized before setup() so it will 'eats' bootup routine, which calls 'ota succesfully'. |
are you sure you're not uploading the merged version of firmware? that's the most common problem when it refuses to update |
|
@recrof 100% sure ;) I did some troubleshooting tests and it seems that code before this PR does still work, so if I upload the official v1.15.0 firmware it will update again. So I guess @petrkr might be onto something with this 'setup()' not being called in latest code? It seems uploading the firmware works, but actually updating fails after this PR. But running the latest Dev still allows to update to code BEFORE this PR it seems.
|
Then try return lines. But those are not compatible with SDK3.x+ So it must be solved somehow differently in iGate, because there they are using official latest Elegant OTA, so they may solved it by different way. Then we must also test if it affects only SDK 2.x, if so, then FIX will be put this ti #ifdef version block |
|
Hmm it seems like it was because of my patched Dev branch for some reason. Firmware v1.15.0 already got this PR merged, so I dont think this PR has anything to do with the problem after all 😅 So for now you can just ignore my comments 🤓 |
Fix build issues with SDK 3.x,
Removed dead code includes in old ElegantOTA
This may replace #2264 update. It will stay on old version, but it works with SDK 3.x aswell