This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Support for GCM priority#90
Closed
Syhids wants to merge 3 commits into
Closed
Conversation
Contributor
|
Thank for your PR. Could you modify SPEC.md also? |
Author
|
Done @cubicdaiya :) |
Author
|
Hey @cubicdaiya, any update on this? :) |
catatsuy
reviewed
Jun 25, 2018
| return fmt.Errorf("the message's RegistrationIDs field must not be nil") | ||
| } | ||
|
|
||
| if string(m.Priority) != "" && m.Priority != "normal" && m.Priority != "high" { |
Contributor
There was a problem hiding this comment.
Why do you need to cast? m.Priority is a string type. m.Priority is assigned "" as a zero value.
Contributor
|
@cubicdaiya |
Author
|
@yutachaos feel free to fork this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.