Skip to content

SAIS diff algorithm; VLE algorithms; feel free to tweak, cut & modify;#9

Closed
r-lyeh-archived wants to merge 1 commit intomendsley:masterfrom
r-lyeh-archived:master
Closed

SAIS diff algorithm; VLE algorithms; feel free to tweak, cut & modify;#9
r-lyeh-archived wants to merge 1 commit intomendsley:masterfrom
r-lyeh-archived:master

Conversation

@r-lyeh-archived
Copy link
Copy Markdown

@r-lyeh-archived r-lyeh-archived commented Apr 1, 2015

  • I have updated README with the new directives.
  • I did not add another header/tag for the VLE variants (enabling VLE breaks backwards compatibility)

- added SAIS diff algorithm
d3e7dd6 
- added VLE streams
- compile as C++ bugfix
- fix for #5 and #1
- feel free to tweak, cut & modify
@r-lyeh-archived
Copy link
Copy Markdown
Author

r-lyeh-archived commented Apr 1, 2015

I think that is all for now. I have had to merge on the run as my patch was based on the old version with h/c glued together : )

@CoolOppo
Copy link
Copy Markdown
Contributor

CoolOppo commented Apr 3, 2015

It might be a good idea to allow these to be used without recompiling the program, but through a flag you can call it with from your shell.

I was looking for an explanation for the differences you've introduced, but Google didn't really turn anything relevant up, and the README doesn't really explain the differences either. I can see that you definitely put some thought into this, but the code is really cryptic and difficult to get a hold of without taking a while to step through a bunch of parts in my head. Are you able to explain what exactly is going on from a higher-level point of view, and the advantages and disadvantages of these new algorithms?

@kornelski kornelski mentioned this pull request Apr 5, 2015
Merged
@r-lyeh-archived
Copy link
Copy Markdown
Author

r-lyeh-archived commented Apr 23, 2015

@CoolOppo, yeah sorry about the terse information.

  • VLE. This change is not backwards compatible. VLE option is just moving from the fixed header of the patch 3x64bit [24 bytes] to something more variable in length, say between [3 and 30]. This is a personal choice and might not be everybody's taste, though. See more info at https://github.com/r-lyeh/vle
  • SAIS. This change should remain backwards compatible. The SAIS option is to avoid a recursion crash as seen in Reported crashes with 4.3 #1. The patch seems to work but needs some more (real) testing, as my usage of bsdiff is quite limited.

@r-lyeh-archived
Copy link
Copy Markdown
Author

r-lyeh-archived commented Apr 23, 2015

I could have sent two PR instead, but got it difficult to do so, as my fork was pretty outdated and diverged too much from base. Sorry about that.

@r-lyeh-archived
Copy link
Copy Markdown
Author

r-lyeh-archived commented Jul 17, 2015

ping @mendsley

@otavio
Copy link
Copy Markdown

otavio commented Jul 12, 2016

Has this been abandonned? if so, why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r-lyeh-archived @CoolOppo @otavio