Address user feedback and prepare new major version release#207
Merged
Address user feedback and prepare new major version release#207
Conversation
* Check existence of java-version file instead of just the directory. * Use show-java-version as a cleaner way to detect Java version. * When using dump-mpr, read the entire output & wait for exit code - so that errors are not streamed to jq. * Log how exactly a Mendix version was detected.
It could potentially be restored later, if build.py would also run the Docker build.
* Clarified requirements and limitations * Added an upgrade guide explaining how to use build.py in existing pipelines * Updated versions
Any pipeline that isn't updated to use build.py will fail to run, as CF Buildpack only works with specific Ubuntu versions.
Clarified that any Python >=3.8 <4 is supported.
* Clarify that the destination directory will be created/cleaned up. * Clarified that build.py should work with Mendix 8, 9 and 10 MPRs/MPKs.
Nidhi251289
approved these changes
Nov 28, 2024
Collaborator
Nidhi251289
left a comment
There was a problem hiding this comment.
All comments are incorporated. Hence, approving this PR.
upgrading-from-v5.md
Outdated
| Docker Buildpack v6 no longer uses CF Buildpack to compile MPR (or MPK) files - to continue supporting newer versions of Mendix, Java and the base OS. | ||
| Instead, a custom `build.py` script will: | ||
|
|
||
| 1. Prepare a clean [Docker context](https://docs.docker.com/build/concepts/context/) in the path specified by `--destination`. All files required to build the app image will be copied to this destination. |
Collaborator
There was a problem hiding this comment.
Should we also mention that the if the destaination directory is not created, it will also create the directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mx dump-mprexit code before sending its output tojqbuild.pyscript in existing pipelines.build.py.