Conversation
Use prebuilt image builder with all Java versions. Download MxBuild inside container (improves layer reuse).
This helps if Docker/Podman runs as a different user. Other changes: * Detect Git commit * Fixed log levels (stdout/stderr can be used for different purposes) * Stop container on termination * Allow to use a prebuilt repository cache * Migrated to ubi9 where possible
* Provide DataDog helper scripts (to test later) * Use stdout_open instead of duplicating stderr_open * Support Docker output format * Improve metadata detection handling * Run build as root (Docker seems to ignore USER when copying files) * Updated integration test
GiriChandana123
approved these changes
Sep 2, 2024
Collaborator
There was a problem hiding this comment.
Reviewed, looks good.
@zlogic I think I do not have write access to the repository, to merge the changes into latest.
Collaborator
|
@zlogic [tests/Integrationtest.sh] |
Member
Author
|
Thank you @GiriChandana123, I've added a PR, could you please take a look? #203 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.pyscript that accepts most inputs (MDA or MPK file, or a project source dir) and produces an extracted MDA directory.ubi9as the base OS.This removes support for building MPR projects using CF Buildpack, and instead builds MPR files outside CF Buildpack.