Skip to content

exclude fullrbf txs from audit and label in visualization #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wiz merged 1 commit into from
Jul 11, 2023
Merged

exclude fullrbf txs from audit and label in visualization #3879

wiz merged 1 commit into from
Jul 11, 2023

Conversation

@mononaut
Copy link
Contributor

@mononaut mononaut commented Jun 19, 2023

This PR resolves #3868 by

  • identifying transactions which may be missing or added in an audit due to being involved in a FullRBF replacement
  • excluding them from the health score calculation
  • showing them in the visualizations
    • same desaturated color as "marginal fee rate"
    • "Full RBF" label in tooltip
Screenshot 2023-06-19 at 6 20 30 PM Screenshot 2023-06-19 at 6 20 39 PM

@mononaut mononaut requested review from softsimon and wiz as code owners June 19, 2023 22:25
@cla-bot cla-bot bot added the cla-signed label Jun 19, 2023
@mononaut mononaut force-pushed the mononaut/audit-exclude-fullrbf branch 2 times, most recently from f6b66cd to 44cc966 Compare July 1, 2023 00:04
@wiz wiz mentioned this pull request Jul 1, 2023
Merged
@mononaut mononaut force-pushed the mononaut/audit-exclude-fullrbf branch from 44cc966 to f196676 Compare July 10, 2023 06:52
@mononaut
Copy link
Contributor Author

mononaut commented Jul 10, 2023

rebased on current master

softsimon
softsimon approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK @ [f196676]

Screenshot 2023-07-10 at 17 24 19

@wiz
Copy link
Member

wiz commented Jul 11, 2023

Tested ACK @ f196676

@wiz wiz merged commit 795e675 into master Jul 11, 2023
@wiz wiz deleted the mononaut/audit-exclude-fullrbf branch July 11, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@softsimon softsimon softsimon approved these changes

@wiz wiz Awaiting requested review from wiz wiz is a code owner

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New badge for "removed" fullrbf transactions

4 participants

@mononaut @wiz @softsimon