fix: skip malformed entities in _remove_spaces_from_entities#4184
Open
Br1an67 wants to merge 1 commit intomem0ai:mainfrom
Open
fix: skip malformed entities in _remove_spaces_from_entities#4184Br1an67 wants to merge 1 commit intomem0ai:mainfrom
Br1an67 wants to merge 1 commit intomem0ai:mainfrom
Conversation
When the LLM returns empty dicts ({}) or dicts missing required keys
(source, relationship, destination) in the entity list, the method
crashes with a KeyError. Filter out invalid entries before processing.
|
|
Contributor
Author
|
Hi — just a gentle bump on this. Happy to make any changes if needed! |
|
We're hitting the same bug independently with Ollama + Memgraph (as opposed to Kuzu in #3907). When the LLM returns relation dicts missing |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the LLM returns empty dicts (
{}) or dicts missing required keys (source,relationship,destination) in the entity deletion list,_remove_spaces_from_entitiescrashes with aKeyError. This happens when the LLM determines no entities need to be deleted but still returns[{}]instead of[].This PR filters out invalid entries before processing — items that are empty or missing any of the three required keys are silently skipped.
Fixes #3907
Type of change
How Has This Been Tested?
4 new tests covering: empty dicts, incomplete dicts, all-empty list, and normal entities.
Checklist: