fix(ts): lazy-load SQLite3 to prevent import time crashes#3919
Closed
shubham-021 wants to merge 2 commits intomem0ai:mainfrom
Closed
fix(ts): lazy-load SQLite3 to prevent import time crashes#3919shubham-021 wants to merge 2 commits intomem0ai:mainfrom
shubham-021 wants to merge 2 commits intomem0ai:mainfrom
Conversation
7 tasks
Contributor
|
Resolved the issue in #4270 . Closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the sdk import
sqlite3at module load time, even when users doesn't configure it. This causes the package to fail in environment where sqlite3 native bindings cannot compile.Future Work : Current used sqlite package doesn't compile under environments like Bun. While this PR fixes the issue for users who doesn't need sqlite in their configuration , we still need a way to make sure it works in every envs.
Fixes #3882
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
/mem0-ts/src/oss/examples/lazy-load-sqlite.ts, running this file crashes the process without the fix when not using sqlite3.Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist