test: Handle Python 3.15 warning coming from transitive dependency pygments#9910
Merged
Conversation
…gments - pygments/pygments#3039 Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
✅ Deploy Preview for meltano canceled.
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideScopes the PyO3 ABI3 compatibility environment variable to the nox uv sync session instead of the global CI environment, and adds a pytest warning filter to suppress a new DeprecationWarning emitted by pygments under Python 3.15. Sequence diagram for pytest handling pygments DeprecationWarningsequenceDiagram
actor Dev as Developer
participant Pytest as pytest
participant Tests as Test_suite
participant Pygments as pygments
Dev->>Pytest: run tests
Pytest->>Tests: execute tests
Tests->>Pygments: use highlighting utilities
Pygments-->>Pytest: emit DeprecationWarning
Pytest->>Pytest: apply filterwarnings
Pytest-->>Dev: report test results without DeprecationWarning
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new filterwarnings entry hard-codes the full deprecation message string, which may change across Python versions; consider matching only on the warning category and module (e.g., via
moduleor a shorter regex) to make the filter more robust.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new filterwarnings entry hard-codes the full deprecation message string, which may change across Python versions; consider matching only on the warning category and module (e.g., via `module` or a shorter regex) to make the filter more robust.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9910 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 285 285
Lines 24739 24739
Branches 1417 1417
=======================================
Hits 23869 23869
Misses 697 697
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SSIA.
Checklist
Was generative AI tooling used to co-author this PR?
Related Issues
Summary by Sourcery
Adjust test configuration to handle a new Python 3.15 deprecation warning from pygments and scope a Pyo3 compatibility flag to nox-managed environments.
Build:
CI:
Tests: