Skip to content

fix: handle case of missing .cmj when trying to inline external field#1067

Merged
anmonteiro merged 7 commits intomainfrom
anmonteiro/fix-virtual-libs
Feb 19, 2024
Merged

fix: handle case of missing .cmj when trying to inline external field#1067
anmonteiro merged 7 commits intomainfrom
anmonteiro/fix-virtual-libs

Conversation

@anmonteiro
Copy link
Copy Markdown
Member

@anmonteiro anmonteiro commented Feb 16, 2024

this is the melange part of the fix for #658.

  • Melange looks for some inlining information in the .cmj files for implementations. When compiling virtual libraries, .cmj files are deferred until a specific implementation has been selected, so they won't be available at this time
  • There's a more thorough explanation in the code about what the fix does.

fixes #658

TODO:

  • add a blackbox-test

Comment thread jscomp/core/lam_compile.ml Outdated
@anmonteiro anmonteiro force-pushed the anmonteiro/fix-virtual-libs branch from f0fe036 to d5e7514 Compare February 17, 2024 04:07
@anmonteiro anmonteiro force-pushed the anmonteiro/fix-virtual-libs branch from d5e7514 to e4e99d3 Compare February 17, 2024 04:10
@anmonteiro anmonteiro merged commit b409141 into main Feb 19, 2024
@anmonteiro anmonteiro deleted the anmonteiro/fix-virtual-libs branch February 19, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot use virtual modules without specify implementation library in libraries

2 participants