Reduce docker image size#394
Merged
meili-bors[bot] merged 1 commit intomeilisearch:mainfrom Jun 5, 2023
Merged
Conversation
alallema
approved these changes
Jun 5, 2023
Contributor
alallema
left a comment
There was a problem hiding this comment.
So cool! Thanks a lot @sanders41 for this PR
LGTM! 🔥
Contributor
|
bors merge |
Contributor
Contributor
|
This message is sent automatically Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle? |
brunoocasali
reviewed
Jun 5, 2023
| WORKDIR /docs-scraper | ||
|
|
||
| RUN apt-get update -y && apt-get install -y python3-pip libnss3 chromium-driver | ||
| RUN : \ |
Member
There was a problem hiding this comment.
What is this : notation in this line RUN : \ @sanders41? I never saw that!
Collaborator
Author
There was a problem hiding this comment.
It just let me split it across multiple lines from the start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
With these changes I got ~ a 43% reduction in the final image size (1.55GB to 877MB). Note that depending on your local files present (virtual environments, etc) you may see slightly different numbers with a build, but it will always be significantly smaller.
Related issue
Fixes #<issue_number>
What does this PR do?
apt-get installsection.dockerignorefilepip3. Because the image ispython:3.10.8-slim-bullseyepipis already included by defaultPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!