Skip to content

Chromium-driver binary is added to Dockerfile #235

Merged
meili-bors[bot] merged 3 commits intomeilisearch:mainfrom
mdraevich:main
Aug 2, 2022
Merged

Chromium-driver binary is added to Dockerfile #235
meili-bors[bot] merged 3 commits intomeilisearch:mainfrom
mdraevich:main

Conversation

@mdraevich
Copy link
Copy Markdown
Contributor

@mdraevich mdraevich commented Jul 31, 2022 •
edited by brunoocasali
Loading

What does this PR do?

Fixes #185 (1 task)

Dockerfile was updated as follows:

  1. Chromium-driver was installed using debian repo.
  2. The speed of build process was optimized by leveraging build cache (more).

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Hope you're doing great,
Matthew

@mdraevich
Copy link
Copy Markdown
Contributor Author

mdraevich commented Aug 1, 2022

Ok, that's quite expected - I did notice the same errors before.

As I found out it's because of Meilisearch API client version (0.18.3) is incompatible with latest Meilisearch stable release (0.28.1).
Everything seems to be working with Meilisearch API client version 0.19.1.

Could I modify Pipfile file in this PR to pass tests or it's better to create a separate issue+PR?

@alallema
Copy link
Copy Markdown
Contributor

alallema commented Aug 1, 2022

Hi @mdraevich,
Thanks for your PR ❤️.

Could I modify Pipfile file in this PR to pass tests or it's better to create a separate issue+PR?

You can do as you like, but I will have to merge #223 before anyway maybe it will be easier to wait until after.

@mdraevich
Copy link
Copy Markdown
Contributor Author

mdraevich commented Aug 1, 2022

Dear @alallema
I've updated mdraevich:main to use updated Meiliserach client API version (0.19.1).

You may ensure the success of tests here.
Waiting for your approval / readiness!

Hope you're fine,
Matthew

alallema
alallema approved these changes Aug 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @mdraevich and for contributing to Meilisearch ❤️
LGTM! 🔥

@alallema
Copy link
Copy Markdown
Contributor

alallema commented Aug 2, 2022

bors merge

@alallema alallema added the enhancement New feature or request label Aug 2, 2022
@meili-bors
Copy link
Copy Markdown
Contributor

meili-bors Bot commented Aug 2, 2022

Build succeeded:

@meili-bors meili-bors Bot merged commit 5863acb into meilisearch:main Aug 2, 2022
@brunoocasali brunoocasali mentioned this pull request Aug 3, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Publish a new Docker image containing Chrome binary

2 participants

@mdraevich @alallema