Align MPFR precision CLI naming and fix MPF complex ordering semantics#92
Merged
Align MPFR precision CLI naming and fix MPF complex ordering semantics#92
Conversation
Co-authored-by: msoos <1334841+msoos@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
Copilot
AI
changed the title
[WIP] Add synthesis elements to Ganak with MPFI support
Align MPFR precision CLI naming and fix MPF complex ordering semantics
Mar 12, 2026
Collaborator
|
@copilot Undo the change on src/main.cpp please. |
Co-authored-by: msoos <1334841+msoos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issues in the MPFR/MPFI integration path: the documented precision flag name did not match the implemented CLI surface, and MPFR-complex ordering used non-strict component-wise comparison, diverging from existing complex ordering semantics.
CLI surface consistency (
--mpfrprecision)--mpfrprecisionas the canonical option for MPFR/MPFI precision.--mpfrprecas a compatibility alias.--mode 6/7/8) to reference--mpfrprecision.Complex ordering correctness (MPFR complex mode)
FGenMPFComplex::larger_than()to strict lexicographic ordering:>=behavior that could misorder values.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.