Fix MPFR/MPFI precision bugs and missing validation#88
Merged
Conversation
…R init calls, missing mpfrprec validation Co-authored-by: msoos <1334841+msoos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with Ganak synthesis and MPFI integration
Fix MPFR/MPFI precision bugs and missing validation
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found and fixed several bugs in the MPFI interval arithmetic integration and MPFR precision handling.
Type truncation in
FGenMPFComplexuint16_tbut member ismpfr_prec_t(long). Values like--mpfrprec 100000silently truncate to34464via100000 & 0xFFFF.Wrong precision in
digit_precision_mpfi()mpfr_init()(MPFR default 53-bit) for temporaries extracting interval endpoints. High-precision intervals lose precision, making endpoints appear identical and reporting bogus maximum digit precision. Now usesmpfr_init2()with the interval's actual precision.Missing
--mpfrprecvalidationmpfr_init2/mpfi_init2.Default precision in
compute_collision_prob()mpfr_init_set_*()(53-bit default) instead of explicit 256-bit precision matching the rest of the collision probability and log-printing code.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.