Skip to content

[Chore] Relax release-gated semgrep gate to fail-on-ERROR (4 pre-existing WARNING bash findings red the release scan) #511

@atlas-apex

Description

@atlas-apex

Driver

The release-gated Security Scan (semgrep r/bash, added #487) failed on its first real run (v2.3.0 tag, run 26980436235): 0 ERROR and 4 WARNING findings. It's configured SEMGREP_FAIL_SEVERITY=WARNING, so any WARNING reds the scan. It runs on the tag push (post-merge) so it did NOT block v2.3.0 — but it will red every release until addressed. Classic brand-new-strict-gate-meets-existing-debt.

Scope

Pick one (decide in the ticket):

  • (a) Relax the gate to fail-on-ERROR — set SEMGREP_FAIL_SEVERITY=ERROR in golden-paths/pipelines/security.yml (and the framework's own .github/workflows/security-scan.yml), keeping WARNING as advisory in the step summary. Recommended — a new scan shouldn't hard-fail releases on pre-existing low-severity lint.
  • (b) Fix/suppress the 4 WARNING findings — pull the 4 from the run, fix or add # nosemgrep: <rule> with justification.
    Either way, document the chosen severity policy.

Acceptance Criteria

  • The release-gated scan no longer reds a clean release on pre-existing WARNING-only findings (gate relaxed OR the 4 resolved)
  • Severity policy documented in the workflow
  • A test release tag run goes green

Glossary

Term Definition
SEMGREP_FAIL_SEVERITY The threshold at/above which a semgrep finding fails the CI job (WARNING vs ERROR).
release-gated scan A security scan that runs on the release tag push rather than on every PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreMaintenance / non-feature work

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions