Skip to content

Dedent virtual markdown chunks#370

Merged
remcohaszing merged 1 commit intomainfrom
dedent-markdown
Dec 14, 2023
Merged

Dedent virtual markdown chunks#370
remcohaszing merged 1 commit intomainfrom
dedent-markdown

Conversation

@remcohaszing
Copy link
Copy Markdown
Member

@remcohaszing remcohaszing commented Dec 14, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

MDX allows to use indentation. In regular markdown however, indented code represents a code block. To work around this, all virtual markdown chunks are now dedented. This may change the semantic meaning of certain markdown, but it doesn’t affect editor features as far as I’m aware.

@remcohaszing
Dedent virtual markdown chunks
0c08e7a 
MDX allows to use indentation. In regular markdown however, indented
code represents a code block. To work around this, all virtual markdown
chunks are now dedented. This may change the semantic meaning of certain
markdown, but it doesn’t affect editor features as far as I’m aware.
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 👍 phase/yes Post is accepted and can be worked on labels Dec 14, 2023
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 14, 2023

⚠️ No Changeset found

Latest commit: 0c08e7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2023

Hi! This is accepted and can go somewhere!

Team: please review this PR and use the area/* (to describe the scope of the change), platform/* (if this is related to a specific one), and semver/* and type/* labels to annotate this.

@remcohaszing remcohaszing merged commit 8690a6a into main Dec 14, 2023
@remcohaszing remcohaszing deleted the dedent-markdown branch December 14, 2023 16:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2023

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@remcohaszing