Conversation
|
|
@Andarist Does this look right to you? |
This messes with the fixture tests.
| npm pack --pack-destination "$PWD" --workspace @mdx-js/language-server | ||
| npx --workspace vscode-mdx vsce package --out "$PWD" | ||
|
|
||
| node scripts/tag-extension.mjs |
There was a problem hiding this comment.
I'd probably tag after creating a successful release (if only you could easily differentiate between that and a failure)
There was a problem hiding this comment.
I don’t really understand why. Tags are already created succesfully. Also I don’t see this in xstate-tools.
There was a problem hiding this comment.
Maybe there is some reason why xstate-tools does it this way. I honestly don't remember ;p It's just my intuition that a tag should be created after releasing and not before it. This is the order in which Changesets does things when it deals with npm publishing: https://github.com/changesets/changesets/blob/93ee679537fb43111c29359fe6c82164b359e4d1/packages/cli/src/commands/publish/index.ts#L90-L102
There was a problem hiding this comment.
Let’s find out then.
|
I briefly looked at this and LGTM |
|
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the |
Initial checklist
Description of changes
The solution is based on
https://github.com/statelyai/xstate-tools/blob/8a5df5db0e96e097b51e58280ae6405f2a0f9f94/scripts/tag-extension.js