Fix dropping local media in an MDX file#357
Merged
remcohaszing merged 1 commit intomainfrom Dec 5, 2023
Merged
Conversation
This was using `URL.canParse`, which isn’t available in the Node.js version used by VSCode. This failed silently. This is fixed by using strict parse mode from `vscode-uri`. Closes #322
🦋 Changeset detectedLatest commit: ac340d5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment has been minimized.
This comment has been minimized.
Member
ChristianMurphy
left a comment
There was a problem hiding this comment.
Code looks fine.
When you have a chance, could you take a look at at the failing test @remcohaszing ?
Member
Author
|
The test failure is unrelated. I’m looking into it, but I’ll merge this as-is. |
This comment has been minimized.
This comment has been minimized.
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was using
URL.canParse, which isn’t available in the Node.js version used by VSCode. This failed silently. This is fixed by using strict parse mode fromvscode-uri.Closes #322