Convert array of class names to a string#158
Merged
timneutkens merged 1 commit intomdx-js:masterfrom Jun 11, 2018
Merged
Conversation
For example, when using `@mapbox/rehype-prism`, the `className` property is an array instead of a string, which meant the classes were stringified with commas between them instead of spaces.
timneutkens
approved these changes
Jun 11, 2018
Member
timneutkens
left a comment
There was a problem hiding this comment.
Just verified that this is the expected result of a HAST AST node. So this is the correct solution. Thanks @devongovett!
Member
|
@devongovett actually looking at it again I'm not sure how this works, as we stringify the |
Contributor
Author
|
ah right I copied and pasted wrong. one sec |
Contributor
Author
This was referenced Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, when using
@mapbox/rehype-prism, theclassNameproperty is an array instead of a string, which meant the classes were stringified with commas between them instead of spaces.