fix(doc): ignore templ-broken-link issues for unavailable content#505
Merged
fix(doc): ignore templ-broken-link issues for unavailable content#505
templ-broken-link issues for unavailable content#505Conversation
templ-broken-link issues for unavailable content
Contributor
|
c7168f9 was deployed to: https://rari-pr505.review.mdn.allizom.net/ |
Contributor
Author
LeoMcA
approved these changes
Jan 30, 2026
Member
LeoMcA
left a comment
There was a problem hiding this comment.
As you briefly mentioned, inverting the function would be nice for readability: otherwise looks good!
crates/rari-doc/src/pages/page.rs
Outdated
| /// | ||
| /// # Returns | ||
| /// `true` if the category's root is not configured; otherwise, `false`. | ||
| pub fn is_unavailable_category(category: PageCategory) -> bool { |
Member
There was a problem hiding this comment.
Yeah might be good to inverse this so it's is_available_category
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ignores
templ-broken-linkissues for unavailable optional content.Also: Fixes a small bug in the function that maps curriculum paths to slug (with tests).
Motivation
Resolves an unexpected flaw:
Macro ? produces link /en-US/curriculum/ which doesn't resolveAdditional details
Before
After
Related issues and pull requests
Fixes #452.