Skip to content

fix(issues): stabilize build --issues output#516

Merged
LeoMcA merged 2 commits intomainfrom
515-sort-issues
Feb 5, 2026
Merged

fix(issues): stabilize build --issues output#516
LeoMcA merged 2 commits intomainfrom
515-sort-issues

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented Feb 3, 2026 •
edited
Loading

Description

Stabilizes build --issues output:

  1. Sort issues by file, line, and column (before writing the file).
  2. Omit issue counter (ic) in output.

Motivation

Make it possible to compare/diff the issues of two builds.

Additional details

Test:

cargo --quiet run --release build --issues issues-1.json
cargo --quiet run --release build --issues issues-2.json
diff issues-1.json issues-2.json | wc -l

Before

Building everything 🛠️
Took:  640.856ms for reading 14080 docs
Took:   16.351ms to build spas (12)
Took:     6.793s to build content docs (14080)
Took:   15.479ms to build search index
Found 3215 issues in 847 of 14092 files
Building everything 🛠️
Took:  610.972ms for reading 14080 docs
Took:   16.736ms to build spas (12)
Took:     6.741s to build content docs (14080)
Took:   16.234ms to build search index
Found 3215 issues in 847 of 14092 files
  106140

After 6dec314

Building everything 🛠️
Took:  605.017ms for reading 14080 docs
Took:   31.150ms to build spas (12)
Took:     7.355s to build content docs (14080)
Took:   11.485ms to build search index
Found 3215 issues in 847 of 14092 files
Building everything 🛠️
Took:  527.058ms for reading 14080 docs
Took:   16.463ms to build spas (12)
Took:     7.048s to build content docs (14080)
Took:   13.057ms to build search index
Found 3215 issues in 847 of 14092 files
   12820

After 2415d9e

Building everything 🛠️
Took:  646.976ms for reading 14080 docs
Took:   29.799ms to build spas (12)
Took:     6.980s to build content docs (14080)
Took:   11.115ms to build search index
Found 3215 issues in 847 of 14092 files
Building everything 🛠️
Took:  603.941ms for reading 14080 docs
Took:   17.405ms to build spas (12)
Took:     6.880s to build content docs (14080)
Took:   12.646ms to build search index
Found 3215 issues in 847 of 14092 files
       0

Related issues and pull requests

Fixes #515.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026 •
edited
Loading

b9ead75 was deployed to: https://rari-pr516.review.mdn.allizom.net/

@caugner caugner force-pushed the 515-sort-issues branch 2 times, most recently from 983f28e to 2415d9e Compare February 3, 2026 15:10
@caugner caugner changed the title fix(cli): make build --issues output deterministic fix(cli): stabilize build --issues output Feb 3, 2026
@caugner caugner changed the title fix(cli): stabilize build --issues output fix(issues): stabilize build --issues output Feb 3, 2026
@caugner caugner marked this pull request as ready for review February 3, 2026 15:14
@caugner caugner requested a review from a team as a code owner February 3, 2026 15:14
@caugner caugner requested a review from LeoMcA February 3, 2026 15:14
LeoMcA
LeoMcA approved these changes Feb 5, 2026
View reviewed changes
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@LeoMcA LeoMcA merged commit 3b1e2be into main Feb 5, 2026
18 checks passed
@LeoMcA LeoMcA deleted the 515-sort-issues branch February 5, 2026 11:03
@mdn-bot mdn-bot mentioned this pull request Feb 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeoMcA LeoMcA LeoMcA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build --issues is not deterministic

2 participants

@caugner @LeoMcA