chore(doc): ignore shared assets when handling images#456
Merged
Conversation
Contributor
|
790b43b was deployed to: https://rari-pr456.review.mdn.allizom.net/ |
LeoMcA
approved these changes
Jan 14, 2026
Member
LeoMcA
left a comment
There was a problem hiding this comment.
It would be nice if the shared-assets repository automatically maintained a JSON file with information about all assets
Have you filed an issue for this? An advantage of this would be we could set the width/height attributes of these images in page (as this function does) to ensure no layout shifts
Contributor
Author
Filed one now: mdn/shared-assets#88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates image handling to ignore shared assets.
Motivation
Prevent errors related to shared assets from showing up in content PR Review Companion comments like this one.
Additional details
It would be nice if the shared-assets repository automatically maintained a JSON file with information about all assets, but since we don't have that, we should better avoid these errors for now, as they're not actionable from a contributor's point of view.
Related issues and pull requests