Skip to content

chore(deps): consume web-features npm package#454

Merged
LeoMcA merged 4 commits intomainfrom
use-web-features-package
Jan 15, 2026
Merged

chore(deps): consume web-features npm package#454
LeoMcA merged 4 commits intomainfrom
use-web-features-package

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented Dec 19, 2025 •
edited
Loading

Description

Use the web-features npm package directly, instead of downloading an artifact from the latest GitHub release.

Also: Removes the associated now obsolete logic for downloading the artifact.

Motivation

Consistency. The data.extended.json has become the data.json included in the web-features npm package.

Additional details

Related issues and pull requests

@caugner caugner requested a review from a team as a code owner December 19, 2025 14:54
@caugner caugner requested a review from LeoMcA December 19, 2025 14:54
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

697b3b3 was deployed to: https://rari-pr454.review.mdn.allizom.net/

@caugner
Copy link
Contributor Author

caugner commented Dec 19, 2025

Hm, https://rari-pr454.review.mdn.allizom.net/en-US/docs/Web/CSS/Reference/Properties/color is missing the Baseline banner, even though https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/color has it. I must have missed something.

@caugner caugner marked this pull request as draft December 19, 2025 15:14
@caugner caugner force-pushed the use-web-features-package branch from b1fed68 to 4a0be7b Compare December 19, 2025 15:18
@caugner
Copy link
Contributor Author

caugner commented Dec 19, 2025

Hm, rari-pr454.review.mdn.allizom.net/en-US/docs/Web/CSS/Reference/Properties/color is missing the Baseline banner, even though developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/color has it. I must have missed something.

This shows up as an error now: https://github.com/mdn/rari/actions/runs/20375814527/job/58554073441?pr=454#step:18:139

ERROR page{locale="en-US" slug="Web/Performance" file="/home/runner/work/rari/rari/mdn/content/files/en-us/web/performance/index.md"}:page{locale="en-US" slug="Web/Performance" file="/home/runner/work/rari/rari/mdn/content/files/en-us/web/performance/index.md"}: rari_doc::baseline: Failed to load web-features data: IoError(RariIoError { path: "/home/runner/.local/share/rari/baseline/package/data.json", source: Os { code: 2, kind: NotFound, message: "No such file or directory" } })

@caugner
chore(deps): consume web-features npm package
fdba3d1
@caugner
chore(deps): remove unused github_release module
86cb3df
@caugner
chore(doc): show error when dependent data is missing
30aaa1e 
Affects:
- Baseline data from web-features npm package
- Spec data from web-specs and @mdn/browser-compat-data npm packages
- WebExtensions example data from the mdn/webextensions-examples repo
@caugner caugner force-pushed the use-web-features-package branch from 13ed1a3 to 30aaa1e Compare December 19, 2025 16:58
@caugner
Copy link
Contributor Author

caugner commented Dec 19, 2025

Hm, rari-pr454.review.mdn.allizom.net/en-US/docs/Web/CSS/Reference/Properties/color is missing the Baseline banner, even though developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/color has it. I must have missed something.

This shows up as an error now: mdn/rari/actions/runs/20375814527/job/58554073441?pr=454#step:18:139

ERROR page{locale="en-US" slug="Web/Performance" file="/home/runner/work/rari/rari/mdn/content/files/en-us/web/performance/index.md"}:page{locale="en-US" slug="Web/Performance" file="/home/runner/work/rari/rari/mdn/content/files/en-us/web/performance/index.md"}: rari_doc::baseline: Failed to load web-features data: IoError(RariIoError { path: "/home/runner/.local/share/rari/baseline/package/data.json", source: Os { code: 2, kind: NotFound, message: "No such file or directory" } })

✅ This is now fixed.

@caugner caugner marked this pull request as ready for review December 19, 2025 17:03
LeoMcA
LeoMcA approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Reduces a bunch of complexity

@LeoMcA LeoMcA merged commit 3ea875c into main Jan 15, 2026
18 checks passed
@LeoMcA LeoMcA deleted the use-web-features-package branch January 15, 2026 08:06
@mdn-bot mdn-bot mentioned this pull request Jan 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeoMcA LeoMcA LeoMcA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caugner @LeoMcA