Skip to content
This repository was archived by the owner on Jun 21, 2022. It is now read-only.

Conversation

@allan-simon
Copy link
Contributor

No description provided.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

@teoli2003 teoli2003 merged commit 2152866 into mdn:master Feb 23, 2018
@allan-simon
Copy link
Contributor Author

sorry to ask but do you have an idea on when it will be available on MDN ? I'm teaching html/css to some chinese friends who don't speak a word of english and that would help them considerably to have the menu on the left in chinese :) (currently they can't navigate and they have bookmarked all the pages to have the title in chinese )

@SphinxKnight
Copy link
Contributor

Hi @allan-simon, the change is now available on MDN. I've force-refreshed https://developer.mozilla.org/zh-CN/docs/learn/HTML and got the right sidebar.
The only issue is that there is no automatic "refresh" of the different pages so one need to log in and force refresh (ctrl-shift-r) the pages that weren't updated yet. (force refresh doesn't work if not logged in)

@SphinxKnight
Copy link
Contributor

@allan-simon, thanks to @jwhitlock, the pages were re-rendered so that manual action isn't required anymore :) (cf. this bug for more details)

@allan-simon
Copy link
Contributor Author

@SphinxKnight awesome, thanks @jwhitlock :)

@allan-simon allan-simon deleted the patch-1 branch March 5, 2018 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants