-
Notifications
You must be signed in to change notification settings - Fork 509
Add example for list-style-type CSS property #594
Conversation
|
💖 Thanks for opening this pull request! 💖 |
|
This looks good, and I love space-counter, but I agree that the presentation of I would suggest instead of side-by-side, having the output and code top-and-bottom. You'll need to add You'll also need to compress the content vertically. I would do things like:
I'd also have an What do you think? It's sad to have only 3 list items, I tried putting all the symbols on one line, but they'll be cut off at narrower widths. |
|
Also, I think space-counter is the best-looking example, so I would make that the initial choice. |
|
I like these suggestions, @wbamberg! I've resized the example like you suggested and space-counter has blasted off to the initial choice. Let me know if you want to see any other changes. Thanks! |
|
This looks great. I noticed that the change introduced a mismatch between the symbols listed in the HTML and the actual symbols in the CSS. I also realised that by reducing the font to I hope you don't mind me pushing them to your branch - it's just to stop you having to go round another review cycle, for things I really should have picked up the first time. |
wbamberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice example @ddbeck !
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
I've updated the page: https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-type :) |
|
@ddbeck , looking at this example, I'd be tempted, now, to move the whole What do you think? I'm sorry to be indecisive about it, and I'd be happy to make the change, unless you wanted to. |
|
@wbamberg Yeah, I understand where you're coming from. I don't think moving the Before settling on that, I wonder what you'd think of this idea. Instead of showing how That would buy us a lot of… room and puts off the complexity to the page for |
I like this! |
|
OK, I'll open a new PR with the new look! |


This PR adds an example for the
list-style-typeCSS property. This is my first attempt at an example (🎉) so I'm open to any and all input on this. One area in particular I'm concerned about is the appearance of the@counter-styledefinition.This ought to fix #483 (which looked unclaimed to me, at the moment).