Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Conversation

@veekas
Copy link

@veekas veekas commented Feb 10, 2018

This updates the interactive demo for the z-index page. It is meant to somewhat mirror the current example on the z-index page.

Current example on MDN

current example

Proposed, interactive example

proposed example

Unfortunately, my linter added 4-space indents to the html that wasn't indented already. Sorry if that makes it more difficult to review the code.

Closes #554

@welcome
Copy link

welcome bot commented Feb 10, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for your contribution.

There's a duplicated example choice, and I don't think this example belongs in "transitions" - perhaps "positioned-layout" fits better?

<button type="button" class="copy hidden" aria-hidden="true">
<span class="visually-hidden">Copy to Clipboard</span>
</button>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This choice is a duplicate of the one before (both z-index: 3;). I think you could just remove one of them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Fixed.

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution @veekas !

@wbamberg wbamberg merged commit 216f866 into mdn:master Feb 16, 2018
@welcome
Copy link

welcome bot commented Feb 16, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants