-
Notifications
You must be signed in to change notification settings - Fork 509
CSS examples: example for z-index #570
Conversation
feat: modify z-index live demo to accomodate small screen widths
|
💖 Thanks for opening this pull request! 💖 |
wbamberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks for your contribution.
There's a duplicated example choice, and I don't think this example belongs in "transitions" - perhaps "positioned-layout" fits better?
| <button type="button" class="copy hidden" aria-hidden="true"> | ||
| <span class="visually-hidden">Copy to Clipboard</span> | ||
| </button> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This choice is a duplicate of the one before (both z-index: 3;). I think you could just remove one of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! Fixed.
wbamberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for your contribution @veekas !
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This updates the interactive demo for the z-index page. It is meant to somewhat mirror the current example on the z-index page.
Current example on MDN
Proposed, interactive example
Unfortunately, my linter added 4-space indents to the html that wasn't indented already. Sorry if that makes it more difficult to review the code.
Closes #554