Add list-style-position css example
#559
Conversation
|
💖 Thanks for opening this pull request! 💖 |
|
Thanks for contributing! I think this is generally very good: however, @helmutgranda just landed an example for the shorthand of this property, For consistency, I think it would be great if the @d7ark, what do you think? I'm sorry not to have made this clear in the bug. |
|
It's fine. No problem. It's definitely doable. I've even seen those changes as pull request. Should've thought of making mine similar. Ill change it and post new version. Thanks. |
wbamberg
left a comment
There was a problem hiding this comment.
This looks great. The only thing I'd say is that it should use the same CSS file as list-style (since it's identical), and live in the same subdirectory.
That said, list-style is in "lists-and-counters" while this example is in "lists". I'm not certain which name we should use here, but it does appear as if "lists" is correct:
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Lists_and_Counters
https://drafts.csswg.org/css-lists-3/
So I'm going to merge this and fix it up later, probably by moving list-style into "lists". But I'd also welcome @schalkneethling 's input :).
Thanks for your contribution @d7ark !
|
Congrats on merging your first pull request! 🎉🎉🎉 |
I agree @wbamberg |
|
I just updated the MDN page: https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-position :) |
Hello. My very first pull request for mdn. I hope everything is alright. Pull's related to #481
I've made two lists ul and ol to highlight that list-style-position works for both.
Looking forward to the feedback (especially on how to make it prettier).