-
Notifications
You must be signed in to change notification settings - Fork 509
Update class expression example #539
Conversation
|
💖 Thanks for opening this pull request! 💖 |
wbamberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks for your contribution @aefhm !
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Thanks @wbamberg. |
|
What is this for? I didn't see this in the style guide and I'm curious. Also, since |
|
As I understand it, the old example incorrectly used a class statement: rather than a class expression:
I did consider this, but the other examples in the page use
...which now seems a little overly-prescriptive. Still, perhaps this should be changed to |
|
Ahh I see, that makes sense. I think var is still okay for ES6 examples since anyone using ES6 will be exposed to it often enough that either works but was just checking. |
|
Ah, I see the documentation on declaring with |
|
I would accept a PR to change [1] Probably not to |
|
Inertia it is. I think we get the same error |
Updating Class Expression Example
Currently, we use a class declaration.
after