Skip to content

fix(homepage-contributor-spotlight): fix content overflow#1045

Merged
LeoMcA merged 5 commits intomdn:mainfrom
brysonbw:homepage-contributor-spotlight-name-overflow-fix
Feb 3, 2026
Merged

fix(homepage-contributor-spotlight): fix content overflow#1045
LeoMcA merged 5 commits intomdn:mainfrom
brysonbw:homepage-contributor-spotlight-name-overflow-fix

Conversation

@brysonbw
Copy link
Contributor

@brysonbw brysonbw commented Oct 31, 2025 •
edited
Loading

Description

Changes

  • Edit homepage-contributor-spotlight__name class styles - prevent name content overflow on mobile screens

Screenshots and screen recordings

Before

contributor-spotlight-overflow-before.mov

After

after-1027.mov

Related issues and pull requests

@brysonbw brysonbw requested a review from a team as a code owner October 31, 2025 06:23
@brysonbw brysonbw requested a review from caugner October 31, 2025 06:23
caugner
caugner requested changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be sufficient to add max-width: 100% to the existing .homepage-contributor-spotlight__name {} rule, where we already set width: max-content.

Setting width: 100% causes the name to take all the space, even if it doesn't need to.

@caugner caugner changed the title fix(homepage-contributor-spotlight): fix contributor spotlight name content overflow fix(homepage-contributor-spotlight): fix content overflow Oct 31, 2025
@brysonbw brysonbw requested a review from caugner November 3, 2025 16:16
caugner
caugner requested changes Nov 4, 2025
View reviewed changes
@brysonbw brysonbw force-pushed the homepage-contributor-spotlight-name-overflow-fix branch from 321ee9b to 1bd6f5f Compare November 5, 2025 03:03
@brysonbw brysonbw requested a review from caugner November 5, 2025 03:05
@brysonbw brysonbw mentioned this pull request Jan 7, 2026
Open
@caugner caugner mentioned this pull request Jan 9, 2026
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026 •
edited
Loading

dd47e77 was deployed to: https://fred-pr1045.review.mdn.allizom.net/

caugner
caugner approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Before

image

After

image

LeoMcA
LeoMcA requested changes Jan 30, 2026
View reviewed changes
@brysonbw brysonbw requested a review from LeoMcA January 31, 2026 00:00
@LeoMcA LeoMcA merged commit bf72208 into mdn:main Feb 3, 2026
9 checks passed
@mdn-bot mdn-bot mentioned this pull request Feb 3, 2026
Merged
@LeoMcA
Copy link
Member

LeoMcA commented Feb 3, 2026

Thank you for fixing this @brysonbw! Apologies for taking so long to review it, @caugner recently put some work in to get the review companion to work on PRs from forks, which makes reviewing much more convenient for us - so we ought to be much faster at it from now on!

@brysonbw
Copy link
Contributor Author

brysonbw commented Feb 4, 2026

Thank you for fixing this @brysonbw! Apologies for taking so long to review it, @caugner recently put some work in to get the review companion to work on PRs from forks, which makes reviewing much more convenient for us - so we ought to be much faster at it from now on!

Np and ok, smooth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caugner caugner caugner approved these changes

@LeoMcA LeoMcA LeoMcA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brysonbw @LeoMcA @caugner