-
Notifications
You must be signed in to change notification settings - Fork 206
Extend syntax.json format #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Elchi3 Why not to merge? 😞 |
|
@lahmatiy Sorry, I should have left an explanation here. We can't merge this now, because MDN relies on the old structure. It is a breaking change and I don't have the time to patch MDN just now. We want to merge this, but later when MDN is patched, or we have published a package and this is in a later version, which MDN doesn't load then. Please have some patience. Update: These two scripts need fixing to work with the changed data structure |
|
This needs a rebase and changes to the schema now. I'll try to unblock us on the MDN/KumaScript side. |
# Conflicts: # css/syntaxes.json
|
@Elchi3 Done |
|
Thanks @lahmatiy! We still need to wait for mdn/kumascript#208 to get merged and deployed. Also it says there is a conflict, can you resolve that or should I? |
|
@Elchi3 Conflict is fixed. |
|
@Elchi3 mdn/kumascript#208 is merged. Is there no blockers now? |
|
Merged, but please wait until mdn/kumascript#208 is deployed, or you'll break MDN. I'm planning on deploying tomorrow morning (in 15 hours or so) |
|
Deployed to staging and production. @Elchi3, ready for merging and manual testing. |
This PR makes
syntax.jsonformat uniform with other dictionaries. Also, this make it possible to extend the description of the syntaxes in the future.Changes based on #41