Skip to content

Conversation

@lahmatiy
Copy link
Contributor

This PR makes syntax.json format uniform with other dictionaries. Also, this make it possible to extend the description of the syntaxes in the future.
Changes based on #41

This was referenced May 11, 2017
@Elchi3 Elchi3 changed the title Extend syntax.json format [DO NOT MERGE] Extend syntax.json format May 16, 2017
@lahmatiy
Copy link
Contributor Author

@Elchi3 Why not to merge? 😞

@Elchi3
Copy link
Member

Elchi3 commented May 18, 2017

@lahmatiy Sorry, I should have left an explanation here. We can't merge this now, because MDN relies on the old structure. It is a breaking change and I don't have the time to patch MDN just now. We want to merge this, but later when MDN is patched, or we have published a package and this is in a later version, which MDN doesn't load then. Please have some patience.

Update: These two scripts need fixing to work with the changed data structure
https://github.com/mozilla/kumascript/blob/master/macros/CSS_Ref.ejs
https://github.com/mozilla/kumascript/blob/master/macros/csssyntax.ejs

@Elchi3
Copy link
Member

Elchi3 commented Jun 13, 2017

This needs a rebase and changes to the schema now. I'll try to unblock us on the MDN/KumaScript side.

@lahmatiy
Copy link
Contributor Author

@Elchi3 Done
I've used latest css/syntax.json and converted it with a script.

@Elchi3
Copy link
Member

Elchi3 commented Jun 14, 2017

Thanks @lahmatiy! We still need to wait for mdn/kumascript#208 to get merged and deployed.

Also it says there is a conflict, can you resolve that or should I?

@lahmatiy
Copy link
Contributor Author

@Elchi3 Conflict is fixed.

@lahmatiy
Copy link
Contributor Author

lahmatiy commented Jun 19, 2017

@Elchi3 mdn/kumascript#208 is merged. Is there no blockers now?

@jwhitlock
Copy link
Contributor

Merged, but please wait until mdn/kumascript#208 is deployed, or you'll break MDN. I'm planning on deploying tomorrow morning (in 15 hours or so)

@jwhitlock
Copy link
Contributor

Deployed to staging and production. @Elchi3, ready for merging and manual testing.

@Elchi3 Elchi3 changed the title [DO NOT MERGE] Extend syntax.json format Extend syntax.json format Jun 20, 2017
@Elchi3 Elchi3 merged commit 0e810b2 into mdn:master Jun 20, 2017
@lahmatiy lahmatiy deleted the patch-7 branch June 20, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants