Skip to content

Details for window.maximize()#9147

Merged
teoli2003 merged 3 commits intomdn:mainfrom
talha-ah:patch-1
Sep 23, 2021
Merged

Details for window.maximize()#9147
teoli2003 merged 3 commits intomdn:mainfrom
talha-ah:patch-1

Conversation

@talha-ah
Copy link
Contributor

@talha-ah talha-ah commented Sep 21, 2021

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'
Not reported yet

What was wrong/why is this fix needed? (quick summary only)
Content was needed for window.maximize()

Anything else that could help us review it

@talha-ah talha-ah requested a review from a team as a code owner September 21, 2021 15:35
@talha-ah talha-ah requested review from Rumyra and removed request for a team September 21, 2021 15:35
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2021 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub
Flaw count: 31

  • macros:
    • /en-US/docs/Web/API/Window/DOMMatrix does not exist
    • /en-US/docs/Web/API/Window/DOMMatrixReadOnly does not exist
    • /en-US/docs/Web/API/Window/DOMPoint does not exist
    • /en-US/docs/Web/API/Window/DOMPointReadOnly does not exist
    • /en-US/docs/Web/API/Window/DOMQuad does not exist
    • and 17 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/The_message_manager
    • Can't resolve /en-US/docs/Mozilla/Tech/XUL/Attribute/onpagehide
    • Can't resolve /en-US/docs/Mozilla/Tech/XUL/Attribute/onpageshow
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 1 more flaws omitted

External URLs

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub

(this comment was updated 2021-09-23 07:43:28.710471)

wbamberg
wbamberg reviewed Sep 22, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! But I think we should:

These functions are apparently XUL-only, which means they are proprietary Firefox functions, which we should not document here.

If you'd like to make these changes, please go ahead :).

teoli2003
teoli2003 suggested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo to fix.

@wbamberg
Copy link
Collaborator

wbamberg commented Sep 22, 2021 •
edited
Loading

@teoli2003 , what do you think about #9147 (review) ?

See also #9175 which is the other part of this, if we agree to delete these links.

@talha-ah talha-ah mentioned this pull request Sep 22, 2021
Merged
@teoli2003
Copy link
Contributor

teoli2003 commented Sep 23, 2021

Oh! Good catch! I missed that it was XUL-only. Yes, of course, like with minimize() this should be delete.

@teoli2003 teoli2003 merged commit 83c900c into mdn:main Sep 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wbamberg wbamberg wbamberg left review comments

@Rumyra Rumyra Awaiting requested review from Rumyra

+1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@talha-ah @wbamberg @teoli2003