Create a new page for CSS sign() function#5192
Conversation
Preview URLsFlawsURL:
External URLsURL: No new external URLs (this comment was updated 2021-09-19 08:00:49.372525) |
|
@rachelandrew Examples updated. Please review. |
|
|
||
| <pre class="brush: css;">div { | ||
| background-position: sign(10%); | ||
| }</pre> |
There was a problem hiding this comment.
You are saying it might resolve one way or another, so I would suggest showing that in the example. As we don't have an implementation of this right now. So if you give this a container (and thus something to resolve against) you can give a clear example of what the value would resolve to.
If we have implementations wouldn't matter so much as people could see/check in DevTools but we need to be a bit more explicit with things that don't have a way to demo them.
There was a problem hiding this comment.
I don't have a better example. We can release the page as is, and let the community add better examples.
There was a problem hiding this comment.
I explained above how to make the example better. At the moment it doesn't really demonstrate anything.
Give the element a container, with a width, then in the explanation to the example explain what the background position would be based on being sign(10%) of the container width. What would it resolve to?
There was a problem hiding this comment.
@rachelandrew can you insert a code suggestion to the PR?
rachelandrew
left a comment
There was a problem hiding this comment.
Couple of inline suggestions and comments
Co-authored-by: Rachel Andrew <me@rachelandrew.co.uk>
Co-authored-by: Rachel Andrew <me@rachelandrew.co.uk>
|
@ramiy It seems maybe this is waiting on your response to the review comment at #5192 (review) |
|
I'm afraid this sat still for too long and, with the conversion of the CSS area to Markdown last week, this will need some extra work. (I wonder why Github doesn't indicate any merge conflict, btw) |
I think that’s just because it’s an entirely new file |
I went ahead and converted it to Markdown. But I’m not sure from who this PR is waiting on action from at this point… |
|
I think this PR is ready for merge. For new suggestions people can create other PRs. |
Create a new MDN page for a new CSS function.
https://developer.mozilla.org/en-US/docs/Web/CSS/sign()
No.
sign()is a functional notation defined in CSS Values and Units Module Level 4.See also: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Functions#math_functions