Skip to content

Create a new page for CSS abs() function#5168

Merged
rachelandrew merged 9 commits intomdn:mainfrom
ramiy:patch-3
May 22, 2021
Merged

Create a new page for CSS abs() function#5168
rachelandrew merged 9 commits intomdn:mainfrom
ramiy:patch-3

Conversation

@ramiy
Copy link
Copy Markdown
Contributor

@ramiy ramiy commented May 20, 2021

What was wrong/why is this fix needed? (quick summary only)

Create a new MDN page for a new CSS function.

MDN URL of the main page changed

https://developer.mozilla.org/en-US/docs/Web/CSS/abs()

Issue number (if there is an associated issue)

No.

Anything else that could help us review it

abs() is a functional notation defined in CSS Values and Units Module Level 4.

See also: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Functions#math_functions

@ramiy ramiy requested a review from a team as a code owner May 20, 2021 22:38
@ramiy ramiy requested review from ericwbailey and removed request for a team May 20, 2021 22:38
@ramiy ramiy changed the title Add CSS abs() function Create a new page for CSS abs() function May 20, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 20, 2021 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/CSS/abs()
Title: abs()
on GitHub
Flaw count: 3

  • macros:
    • `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/CSSSyntax.ejs:1

1| <%
2| /*
3| Displays the syntax of a CSS property or descriptor
4|

No syntax found in DB for 'abs()'`

  • /en-US/docs/Web/CSS/sign does not exist
  • bad_bcd_queries:
    • No BCD data for query: css.types.abs

External URLs

URL: /en-US/docs/Web/CSS/abs()
Title: abs()
on GitHub

No new external URLs

(this comment was updated 2021-05-22 09:07:12.146150)

@ramiy ramiy mentioned this pull request May 20, 2021
Merged
rachelandrew
rachelandrew requested changes May 21, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I've been working through the CSS functions trying to give each a page, couple of suggestions inline but I would take a look at the calc() page as a good example, although as I don't think this has any support yet we won't add an interactive example at the top.

rachelandrew
rachelandrew requested changes May 21, 2021
View reviewed changes
ramiy and others added 3 commits May 22, 2021 02:09
@ramiy @rachelandrew
Update first example
97a22ff 
Co-authored-by: Rachel Andrew <me@rachelandrew.co.uk>
@ramiy
Explain the second example
0d273da
@ramiy
fix {{CSSxRef}}
d0791f0
rachelandrew
rachelandrew approved these changes May 22, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@rachelandrew rachelandrew merged commit f4556b8 into mdn:main May 22, 2021
@ramiy ramiy deleted the patch-3 branch May 22, 2021 19:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rachelandrew rachelandrew rachelandrew approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ramiy @ericwbailey @rachelandrew