Update JavaScript for...in syntax block#5079
Merged
sideshowbarker merged 1 commit intomdn:mainfrom May 19, 2021
Merged
Conversation
Add missing angled brackets (`{ }`) missing from `for...in` syntax example.
Adjust HTML formatting in line with `for...of` syntax.
https://github.com/mdn/content/blob/f9d710480812705f184665a3bd42de55e9ab098f/files/en-us/web/javascript/reference/statements/for...of/index.html#L27-L30
Collaborator
|
@Elchi3 , what should the syntax section look like for this kind of language feature? |
Contributor
Preview URLsFlawsURL:
External URLsURL: No new external URLs |
Contributor
Author
sideshowbarker
approved these changes
May 19, 2021
Member
|
Gonna go ahead and land this, since as noted in the description and at #5079 (comment), this is making it consistent with how we currently format the So if we decide we need to do something different than this for the Syntax sections, we can change it later — in both places. |
Member
|
Eric, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉 |
Contributor
Author
|
@sideshowbarker thanks heaps, glad to help out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing angled brackets (
{ }) missing fromfor...insyntax example.Angled brackets (
{ }) were missing from the JavaScriptfor...insyntax example.https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in
N/A
I am matching the HTML and code snippet example of the for...of page:
for...ofMDN pagefor...ofsyntax HTML format:content/files/en-us/web/javascript/reference/statements/for...of/index.html
Lines 27 to 30 in f9d7104