Element.attachShadow() - doc for options.customElementRegistry#43593
Merged
chrisdavidmills merged 5 commits intomdn:mainfrom Apr 6, 2026
Merged
Conversation
8 tasks
Contributor
|
Preview URLs (2 pages) (comment last updated: 2026-04-06 00:53:05) |
0fe36cf to
d502a02
Compare
chrisdavidmills
requested changes
Mar 31, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
@hamishwillee a few bits for you to look at, but this is mostly fine!
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
chrisdavidmills
approved these changes
Apr 6, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
All looking good, nice one, @hamishwillee!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
customElementRegistryoption for theElement.attachShadow()Fixes #43237
Fixes #38266
Related docs work can be tracked in #43555