Ff149 allow more chars in attributes/element names#43350
Merged
hamishwillee merged 6 commits intomdn:mainfrom Mar 23, 2026
Merged
Ff149 allow more chars in attributes/element names#43350hamishwillee merged 6 commits intomdn:mainfrom
hamishwillee merged 6 commits intomdn:mainfrom
Conversation
Contributor
hamishwillee
commented
Mar 6, 2026
hamishwillee
commented
Mar 6, 2026
hamishwillee
commented
Mar 6, 2026
hamishwillee
commented
Mar 6, 2026
hamishwillee
commented
Mar 6, 2026
8 tasks
hamishwillee
commented
Mar 9, 2026
hamishwillee
commented
Mar 10, 2026
febf052 to
f600acb
Compare
f600acb to
2643011
Compare
Includes: - Document.createAttribute()/createAttributeNS() - Document.setAttribute()/setAttributeNS() - Document.createElement()/createElementNS() - Element.toggleAttribute() - DOMImplementation.createDocument() - CustomElementRegistry.whenDefined()/define()
2643011 to
2745030
Compare
hamishwillee
commented
Mar 10, 2026
chrisdavidmills
requested changes
Mar 13, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
@hamishwillee a bunch of suggestions to sift through, but nothing serious. Nice work!
hamishwillee
commented
Mar 20, 2026
hamishwillee
commented
Mar 20, 2026
hamishwillee
commented
Mar 20, 2026
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
hamishwillee
commented
Mar 20, 2026
hamishwillee
commented
Mar 20, 2026
hamishwillee
commented
Mar 20, 2026
hamishwillee
commented
Mar 20, 2026
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Collaborator
Author
|
Thanks very much @chrisdavidmills - I accepted all your suggestions. |
chrisdavidmills
approved these changes
Mar 20, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
I have found a broken link, and I also added another suggestion for your consideration, which you can take or leave.
I will approve this now, so you can merge when ready. I don't think I need to see this again.
Cheers, @hamishwillee!
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF149 adds support for additional characters to be used in attribute and element names in https://bugzilla.mozilla.org/show_bug.cgi?id=1773312. Previoulsy the DOM allowed you to only create them with XML characters, now the rules are less restrictive.
This adds docs updates.
Related docs work can be tracked in #43218