Improve documentation on <url> #35029#43292
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Thanks @Sacrafex
I'm deferring proper rview to @estelle as I'm not as familiar with CSS as with Web APIs.
A few comments though:
- Any additions like this should be before the specifications macro/section. Generally either in the top overview, or under a description heading, after the value section.
- I'm not sure if this overstates the effect of CORS. Do all of these actually get blocked on the major browsers (I'm not sure they are).
- Also many CSS fetches woudl be in no-cors mode - so while correct, it feels excessive.
- File URL section true, but not sure if this is the rright place.
It might be that all of this should be a see also link to more general URL docs. Let's see what @estelle says.
|
Thanks for the comments. I'll take a look once I get a chance. |
Sacrafex
left a comment
There was a problem hiding this comment.
I've updated the Docs with working links and a more accurate description. Please let me know if I need to make fixes and another PR.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Preview URLs (1 page) Flaws (1) Found an unexpected or unresolvable flaw? Please report it here. URL:
(comment last updated: 2026-03-08 22:23:21) |
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Clarified the URL value requirement in the documentation.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Clarified CORS validation requirements for CSS properties using <url> values and added information about local file access issues.
Sacrafex
left a comment
There was a problem hiding this comment.
Updated Requested Changes. Please let me know I should update anything else.
estelle
left a comment
There was a problem hiding this comment.
basic syntax-like examples can go into the description section. The examples section is more for in-depth examples generally with live rendering.
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Clarified the description of URL values and updated examples.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
estelle
left a comment
There was a problem hiding this comment.
looks good. Thank you. Just one last suggestion on breaking up the examples in the description
|
@hamishwillee OK to merge? |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
|
We should be good to merge now. If there are any final tweaks you’d like, just let me know and I’d be happy to make them. |
Clarified CORS requirements for certain CSS properties referencing external resources.
Sacrafex
left a comment
There was a problem hiding this comment.
Added Documentation on <url>
Includes examples, definitions & clarifications.
|
No problem. I'm glad to help out. I look forward to making more contributions in the future. |
Added Further clarification to the
file:behavior for the<url>CSS data type as fixes for #35030Description
Motivation
To help readers understand browser restrictions when using
<url>values.Additional details
Linked to MDN CORS guide.
Clarified differences and
file:URL limitations.Related issues and pull requests
#35030