Fix redefinitions of legacy iframe attributes#42542
Merged
chrisdavidmills merged 1 commit intomdn:mainfrom Jan 12, 2026
Merged
Conversation
Contributor
|
Preview URLs |
Contributor
Author
|
@chrisdavidmills Please don't forget about this PR 🙂 |
chrisdavidmills
approved these changes
Jan 12, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
LGTM; thanks, @bban160!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct the stated redefinitions of
allowfullscreenandallowpaymentrequestas per the relevant specs.Motivation
The existing text states that
allowfullscreenis redefined asallow="fullscreen"(shorthand forallow="fullscreen 'src'") andallowpaymentrequestis redefined asallow="payment"(shorthand forallow="payment 'src'"). In reality, both have allowlists of*, which makes a difference if the iframe is navigated away from the origin defined in itssrcattribute.Additional details
allowfullscreen:allowpaymentrequest:allowpaymentrequestis equivalent toallow="fullscreen *"instead ofallow="payment *")