Navigation.reload() does not trigger popstate event#42303
Merged
Conversation
Contributor
|
Preview URLs (comment last updated: 2025-12-15 00:11:54) |
This was referenced Dec 8, 2025
bsmth
reviewed
Dec 12, 2025
Co-authored-by: Brian Smith <brian@smith.berlin>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38229
Navigation.reload()reloads the current page - a soft navigation because data is not fetched from the server. This change adds a note that this action does not fire thepopstateevent.@noamr Points out that it does fire for other soft navigations, so people might expect it to fire for this one.
I "weakly" disagree. If you look at the documentation of
popstateit pretty clearly requires a modification to the history stack, which this does not cause. That said, I'm not an expert, and I don't think this does harm.If the reviewer rejects this I will not be unhappy.
This is part of work for #42254