Editorial review: Document the ToggleEvent.source property#40533
Conversation
|
Preview URLs
(comment last updated: 2025-08-05 09:14:34) |
|
Can I get a tech review, please, @josepharhar? I'm on vacation for a week next week, so there might be a bit of a delay getting it merged. |
|
Thanks for the review, @josepharhar! I think I've fixed everything, but let me know if you have any more concerns. I'll move this on to the editorial review stage now. |
|
@hamishwillee are you OK to give this one an editorial review? I know you've got previous with the popover API. |
hamishwillee
left a comment
There was a problem hiding this comment.
A few comments, but it looks good. Does this need to be added to https://developer.mozilla.org/en-US/docs/Web/API/Popover_API/Using
@hamishwillee OK, I've added short sections to the "Using..." guide covering the |
hamishwillee
left a comment
There was a problem hiding this comment.
@chrisdavidmills - looks good. Thanks for sorting out the using guide as well - I quite like the level you did this at.
One nit, but approving so you can choose to ignore if you like https://github.com/mdn/content/pull/40533/files#r2252790724
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
@hamishwillee superb, thanks for the great review! |
Description
Chrome 140 adds support for the
ToggleEvent.sourceproperty. See #39723 for details.This PR adds documentation for the new property.
Motivation
Additional details
Related issues and pull requests
Fixes #39723.