Skip to content

Reference for stage 3 temporal#37344

Merged
Josh-Cena merged 46 commits intomdn:mainfrom
Josh-Cena:temporal
Jan 20, 2025
Merged

Reference for stage 3 temporal#37344
Josh-Cena merged 46 commits intomdn:mainfrom
Josh-Cena:temporal

Conversation

@Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena commented Dec 23, 2024 •
edited
Loading

#27745

Far from ready for review, and I'll work on this alone for a while

It is now ready for review! It's extremely big but I think it's more worthwhile getting it in as a whole. I`m already leaving the guide to a second PR.

For reviewers (both editorial and technical): I've made a spreadsheet here: https://docs.google.com/spreadsheets/d/1RrRHL0m08R4V4WtuWBbSWr9a1gO4RiIaH42WrPv_Uhs/edit Welcoming anyone on the team for editorial reviews! Technical review from the champion group is greatly appreciated too. It seems we have roughly 4 weeks to make this happen.

@github-actions github-actions bot added Content:JS JavaScript docs size/xl [PR only] >1000 LoC changed labels Dec 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

Preview URLs (282 pages)
External URLs (41)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON
Title: JSON

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal
Title: Temporal

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainDate
Title: Temporal.PlainDate

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainDate/day
Title: Temporal.PlainDate.prototype.day

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/Instant
Title: Temporal.Instant

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainYearMonth
Title: Temporal.PlainYearMonth

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/ZonedDateTime
Title: Temporal.ZonedDateTime

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/ZonedDateTime/day
Title: Temporal.ZonedDateTime.prototype.day

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/ZonedDateTime/add
Title: Temporal.ZonedDateTime.prototype.add()

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/ZonedDateTime/since
Title: Temporal.ZonedDateTime.prototype.since()

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainDateTime
Title: Temporal.PlainDateTime

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainMonthDay
Title: Temporal.PlainMonthDay

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/Duration
Title: Temporal.Duration

TRUNCATED!

@Josh-Cena Josh-Cena mentioned this pull request Dec 25, 2024
Closed
@Josh-Cena Josh-Cena mentioned this pull request Jan 3, 2025
Merged
@Josh-Cena Josh-Cena marked this pull request as ready for review January 3, 2025 09:04
@Josh-Cena Josh-Cena requested a review from a team as a code owner January 3, 2025 09:04
@Josh-Cena Josh-Cena requested review from chrisdavidmills and hamishwillee and removed request for a team January 3, 2025 09:04
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jan 14, 2025
bsmth
bsmth reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments for Conversion group, nearly there

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jan 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jan 16, 2025
bsmth
bsmth reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments in Serialization group

bsmth
bsmth reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last ones on Temporal.Duration

bsmth
bsmth approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Some comments for you to check, but I'm more than happy to leave a +1, well done 👏🏻

@Josh-Cena
Copy link
Member Author

Josh-Cena commented Jan 16, 2025

I plan to merge it some time next week, because I currently have another PR that depends on the Intl changes, and I also need to work on the guide. People are encouraged to leave comments as early as possible, but we can definitely accept follow-up PRs, preferably for bug fixes, especially from the champion group.

This was referenced Jan 20, 2025
Merged
Merged
Merged
@Josh-Cena
Copy link
Member Author

Josh-Cena commented Jan 20, 2025

@printfn Done, thanks for pointing out! I plan to merge it today, so if you have or don't have more comments please feel free to send them.

@Josh-Cena Josh-Cena changed the title [new-ci] Reference for stage 3 temporal Reference for stage 3 temporal Jan 20, 2025
@Josh-Cena
Copy link
Member Author

Josh-Cena commented Jan 20, 2025

I'm going to go ahead and merge it. Thanks everyone! I understand that this is not the final version, and we will surely continue to iterate on it.

@Josh-Cena Josh-Cena merged commit a4e9bce into mdn:main Jan 20, 2025
9 checks passed
@Josh-Cena Josh-Cena deleted the temporal branch January 20, 2025 22:28
@justingrant
Copy link
Contributor

justingrant commented Jan 22, 2025

Thanks so much @Josh-Cena for making this happen!

Also grateful for @meyerweb for all the work you did on the docs previously, and in helping to review this PR.

Developers worldwide are going to be thankful. 🙏

This was referenced Feb 1, 2025
Merged
Merged
@ptomato ptomato mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bsmth bsmth bsmth approved these changes

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee

+3 more reviewers

@justingrant justingrant justingrant left review comments

@printfn printfn printfn left review comments

@meyerweb meyerweb meyerweb requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:JS JavaScript docs size/xl [PR only] >1000 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Josh-Cena @justingrant @fiji-flo @chrisdavidmills @meyerweb @printfn @bsmth