chore(http): Refresh headers ~[s->x]#36862
Merged
Conversation
bsmth
commented
Nov 19, 2024
files/en-us/web/http/headers/service-worker-navigation-preload/index.md
Outdated
Show resolved
Hide resolved
bsmth
commented
Nov 19, 2024
Contributor
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
bsmth
commented
Nov 27, 2024
Member
Author
Yes, I can imagine - thank you very much 🙏🏻 |
bsmth
commented
Dec 6, 2024
hamishwillee
reviewed
Dec 8, 2024
hamishwillee
reviewed
Dec 8, 2024
hamishwillee
reviewed
Dec 8, 2024
hamishwillee
approved these changes
Dec 8, 2024
Collaborator
hamishwillee
left a comment
There was a problem hiding this comment.
Thanks @bsmth
I've added few minor comments/nits which you may or may not wish to consider. I think this all works. Approving for you to merge when you are happy,
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Member
Author
|
Thank you Hamish for the patience and review rounds on this, the feedback has been really valuable 🙏🏻 I'm going to land this one now and look at the TODOs as follow-up tasks. |
Collaborator
|
You are most welcome. Feels good when stuff like this goes in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refreshes a few HTTP headers pages.
common changes:
The HTTP **`Header-Name`** (request|response) headerin first sentence{{HTTPStatus("406", "406 Not Acceptable")}}Motivation
Keeping content up-to-date, fixing formatting, unifying writing conventions
Additions:
TODOs