Remove reference to NaN heading value #35469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches specification change in w3c/geolocation#173 and discussion about existing implementations in w3c/geolocation#171.
7 tasks
Member
|
Did any browser ship with |
Contributor
|
Preview URLs (comment last updated: 2024-08-24 00:34:48) |
Contributor
Author
We don't believe so. |
Josh-Cena
requested changes
Aug 14, 2024
Member
Josh-Cena
left a comment
There was a problem hiding this comment.
Could you update https://developer.mozilla.org/en-US/docs/Web/API/GeolocationCoordinates/heading too?
Contributor
Author
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the reference to the
headingfield being set toNaNwhenspeedis0. This matches the specification change in w3c/geolocation#173.Motivation
As discussed in w3c/geolocation#171, existing implementations do not provide the
NaNvalue previously required by the specification and so the specification has been changed. Documentation such as MDN should also be updated to reflect this reality and avoid developer confusion around whether this is a potential value returned by the API.