Skip to content

Add optional_host_permissions docs#33811

Merged
rebloor merged 12 commits intomdn:mainfrom
rebloor:Add-optional_host_permissions-docs
Jul 17, 2024
Merged

Add optional_host_permissions docs#33811
rebloor merged 12 commits intomdn:mainfrom
rebloor:Add-optional_host_permissions-docs

Conversation

@rebloor
Copy link
Copy Markdown
Contributor

@rebloor rebloor commented May 29, 2024

Description

Adds documentation for optional_host_permissions in support of Bug 1766026 Add optional_host_permissions in mv3 including:

  • new optional_host_permissions key page
  • updates to optional_permissions key page re specification of hosts
  • update to permissions key page host permissions section to explain the various options for requesting host permissions (given that this is the de facto reference point for host permissions information)
  • release note

Related issues and pull requests

Related BCD changes in mdn/browser-compat-data#23177

@rebloor rebloor added the Content:WebExt WebExtensions docs label May 29, 2024
@rebloor rebloor requested a review from zombie May 29, 2024 04:04
@rebloor rebloor self-assigned this May 29, 2024
@github-actions github-actions Bot added Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels May 29, 2024
Comment thread files/en-us/mozilla/add-ons/webextensions/api/permissions/permissions/index.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2024

Preview URLs

Flaws (1)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/optional_host_permissions
Title: optional_host_permissions
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: webextensions.manifest.optional_host_permissions
External URLs (3)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/optional_permissions
Title: optional_permissions


URL: /en-US/docs/Mozilla/Firefox/Releases/128
Title: Firefox 128 for developers

(comment last updated: 2024-07-17 02:34:08)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions Bot added the merge conflicts 🚧 [PR only] label Jun 4, 2024
@github-actions github-actions Bot removed the merge conflicts 🚧 [PR only] label Jun 4, 2024
Comment thread files/en-us/mozilla/add-ons/webextensions/api/permissions/contains/index.md Outdated
Comment thread files/en-us/mozilla/add-ons/webextensions/api/permissions/contains/index.md Outdated
Comment thread files/en-us/mozilla/add-ons/webextensions/api/permissions/contains/index.md Outdated
Comment thread files/en-us/mozilla/add-ons/webextensions/api/permissions/index.md Outdated
Comment thread files/en-us/mozilla/add-ons/webextensions/api/permissions/permissions/index.md Outdated
Comment thread files/en-us/mozilla/add-ons/webextensions/api/permissions/remove/index.md Outdated
Comment thread files/en-us/mozilla/add-ons/webextensions/api/permissions/request/index.md Outdated
Comment thread files/en-us/mozilla/add-ons/webextensions/api/permissions/contains/index.md Outdated
rebloor added 2 commits June 5, 2024 11:29
Addition of link to optional_host_permissions in the host permission section of the permissions manifest key page
Comment thread files/en-us/mozilla/add-ons/webextensions/manifest.json/permissions/index.md Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@rebloor rebloor marked this pull request as ready for review June 5, 2024 02:03
@rebloor rebloor requested review from a team as code owners June 5, 2024 02:03
@rebloor rebloor requested review from dotproto and removed request for a team June 5, 2024 02:03
@rebloor rebloor requested review from hamishwillee and removed request for a team June 5, 2024 02:03
@rebloor rebloor requested a review from zombie June 5, 2024 02:07
@hamishwillee hamishwillee removed their request for review June 7, 2024 01:28
@github-actions github-actions Bot added the merge conflicts 🚧 [PR only] label Jun 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Copy Markdown
Member

@zombie zombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm.

@rebloor rebloor requested a review from a team as a code owner July 17, 2024 02:28
@rebloor rebloor requested review from bsmth and removed request for a team July 17, 2024 02:28
@github-actions github-actions Bot removed the merge conflicts 🚧 [PR only] label Jul 17, 2024
Copy link
Copy Markdown
Contributor

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor changes requested. Pre-approving to avoid blocking.

Co-authored-by: Simeon Vincent <svincent@gmail.com>
@rebloor rebloor merged commit 965d924 into mdn:main Jul 17, 2024
@rebloor rebloor deleted the Add-optional_host_permissions-docs branch July 17, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Firefox Content in the Mozilla/Firefox subtree Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants