Disable individual static rules in DNR#33733
Merged
Conversation
Contributor
|
Preview URLs
External URLs (1)URL:
(comment last updated: 2024-06-12 03:03:48) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rpl
requested changes
May 27, 2024
Comment on lines
+32
to
+34
| ## Examples | ||
|
|
||
| {{WebExtExamples}} |
Member
There was a problem hiding this comment.
Question: do we have an example snippet that is meant to be interpolated here? or should we omit this section in this PR and introduce the section back in a separate PR if we want to followup with a code snippet example?
Contributor
Author
There was a problem hiding this comment.
None that I'm aware of.
rebloor
commented
May 28, 2024
Comment on lines
+32
to
+34
| ## Examples | ||
|
|
||
| {{WebExtExamples}} |
Contributor
Author
There was a problem hiding this comment.
None that I'm aware of.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
rpl
approved these changes
Jun 11, 2024
Member
rpl
left a comment
There was a problem hiding this comment.
@rebloor thanks a lot, apologies for not having been able to come back to this PR last week, this PR looks good and there are only two tweaks to the wording we discussed that seems to need to be applied before merging it.
r+wc, where "with comments" part referring to applying the tweaks to the wording from https://github.com/mdn/content/pull/33733/files#r1627480918 and https://github.com/mdn/content/pull/33733/files#r1616558474
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provides documentation for Bug 1810762 [DNR] Disable individual static rules, including:
getDisabledRuleIdsandupdateStaticRulesRelated issues and pull requests
BCD changes in mdn/browser-compat-data#23168